fix: add tvOS availability annotations for iOS 26 APIs#508
Open
oscnord wants to merge 1 commit intocallstack:mainfrom
Open
fix: add tvOS availability annotations for iOS 26 APIs#508oscnord wants to merge 1 commit intocallstack:mainfrom
oscnord wants to merge 1 commit intocallstack:mainfrom
Conversation
Several iOS 26 APIs used in the library lack tvOS availability annotations, causing compilation failures when building for tvOS: - `TabViewBottomAccessoryPlacement` needs `tvOS 26.0` availability - `.tabViewBottomAccessory` modifier is unavailable on tvOS — excluded via `#if` - `TabBarMinimizeBehavior` enum values (.never, .onScrollUp, .onScrollDown) are unavailable on tvOS — falls back to `.automatic` - `tabBarMinimizeBehavior` view modifier needs `tvOS 26.0` availability check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Building for tvOS fails with compilation errors because several iOS 26 APIs lack tvOS availability annotations.
Errors fixed:
BottomAccessoryProvider.swift—TabViewBottomAccessoryPlacementneeds@available(tvOS 26.0)NewTabView.swift—.tabViewBottomAccessorymodifier is unavailable on tvOS, excluded via#if !os(tvOS)TabViewProps.swift—TabBarMinimizeBehaviorenum values (.never,.onScrollUp,.onScrollDown) are unavailable on tvOS, falls back to.automaticTabViewImpl.swift—tabBarMinimizeBehaviormodifier needstvOS 26.0in#availablecheckChanges:
tvOS 26.0to@available/#availableannotations where the API exists on tvOStabViewBottomAccessoryandBottomAccessoryRepresentableViewfrom tvOS via#if(API doesn't exist on tvOS at all)tvOS 26.0from the#available(iOS 26.0, tvOS 26.0, visionOS 3.0, *)check inNewTabView.swift— the original included tvOS in the runtime check, buttabViewBottomAccessorydoesn't exist on tvOS even in 26.0, so the check would pass but compilation would fail. The block is now excluded at compile time via#if os(tvOS)instead..automaticforMinimizeBehavior.convert()on tvOS (same as macOS)Tested: